Allow empty MetricDescriptor.label_keys
#611
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@samn if you sign the CLA we can merge this. |
so metrics without tags can be used. A `View`'s columns are used as the `MetricDescriptor`'s `label_keys`, and the [docs](https://opencensus.io/stats/view/) say that they're optional. This change preserves the behavior when the `label_keys` are `None`, or if any values are `None`. This matches the behavior of the [Java API](https://github.com/census-instrumentation/opencensus-java/blob/08d09c48a40b7dc6b5dba8603795084fc6ea9695/api/src/main/java/io/opencensus/metrics/export/MetricDescriptor.java#L53-L54).
samn
force-pushed
the
allow-empty-metric-label-keys
branch
from
cdfae54
to
a853bf1
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
so metrics without tags can be used. A
View's columns are used as theMetricDescriptor'slabel_keys, and thedocs say that they're optional.
This change preserves the behavior when the
label_keysareNone, or ifany values are
None.This matches the behavior of the Java
API.