Batch exporting spans once a while #63
Conversation
liyanhui1228
changed the title
liyanhui1228
changed the title
|
|
||
| def export(self, trace): | ||
| def emit(self, trace): |
There was a problem hiding this comment.
Can you add emit() to base.Exporter, and add doc comments explaining emit() and export()?
The naming is a little weird, since I don't usually think of "transport" for something that's just printing or appending to a file. But I don't have a better suggestion.
|
|
||
|
|
||
| class _Worker(object): | ||
| def __init__(self, exporter, grace_period=_DEFAULT_GRACE_PERIOD, |
There was a problem hiding this comment.
The google-cloud-python code which inspired this is well documented, e.g. https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/logging/google/cloud/logging/handlers/transports/background_thread.py#L65 . Can you write/copy doc comments into this code to match?
It would be nicest if we could both use the same code, but I don't think that's feasible right now.
| @@ -62,12 +63,14 @@ def __init__( | |||
| service_name='my_service', | |||
| host_name=DEFAULT_HOST_NAME, | |||
| port=DEFAULT_PORT, | |||
| endpoint=DEFAULT_ENDPOINT): | |||
| endpoint=DEFAULT_ENDPOINT, | |||
| transport=sync.SyncTransport): | |||
trace/tests/system/flask/main.py
Outdated
| from opencensus.trace.exporters.transports import background_thread | ||
| exporter = stackdriver_exporter.StackdriverExporter( | ||
| transport=background_thread.BackgroundThreadTransport) | ||
|
|
There was a problem hiding this comment.
To check my understanding, the flask test uses async transport and the django test uses sync transport? I think this is a good idea, but we should add a comment here and in the django test explaining that they are intentionally different to test both code paths.
There was a problem hiding this comment.
Yes correct. Comment added.
Closes #59
This PR is doing the following things: