Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Metrics - Incoming Requests Per Second #758

Merged
merged 12 commits into from Aug 19, 2019

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Aug 8, 2019

Part of [#695]. Standard metric for incoming requests per second. Incoming requests are under "http_requests".
Track incoming requests to an HTTPServer on the application. Currently, incoming requests are shown "performanceCounters" table in Kusto.

image

@lzchen lzchen requested review from reyang and c24t August 8, 2019 21:32
@lzchen
Copy link
Contributor Author

lzchen commented Aug 8, 2019

If you look at the attached image, the category for this metric is "ASP.NET application" which is actually not accurate. Maybe it would be more appropriate to put this as a custom metric instead.

Copy link
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang
Copy link
Contributor

reyang commented Aug 16, 2019

BTW, remember to update the changelog.

@lzchen lzchen merged commit cde62c5 into census-instrumentation:master Aug 19, 2019
lzchen added a commit to lzchen/opencensus-python that referenced this pull request Aug 26, 2019
…on#758)

* Incoming requests for Python3

* python2 support

* change namespace

* add tests

* More tests

* Fix lint

* Fix lint

* Add test

* Add CHANGELOG
lzchen added a commit that referenced this pull request Aug 26, 2019
* Bump versions

* Apply Requests library spec fidelity

* Fixes value for `http.route` in Flask middleware

* Standard Metrics - Incoming Requests Per Second  (#758)

* Incoming requests for Python3

* python2 support

* change namespace

* add tests

* More tests

* Fix lint

* Fix lint

* Add test

* Add CHANGELOG

* Hotfix/django flask pyramid status code

* Fixed requests contrib to raise original exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants