Fixed requests contrib to raise original exceptions #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoraugustolls
requested review from
c24t,
reyang,
songy23 and
a team
as code owners
lzchen
reviewed
Aug 22, 2019
| ([#755](https://github.com/census-instrumentation/opencensus-python/pull/755)) | ||
| - Added `http code` to `grpc code` status code mapping on `utils` | ||
| ([#746](https://github.com/census-instrumentation/opencensus-python/pull/746)) | ||
| - Updated `requests` module | ||
| ([#771](https://github.com/census-instrumentation/opencensus-python/pull/771)) |
There was a problem hiding this comment.
Do we need to update the CHANGELOG for the core sdk?
There was a problem hiding this comment.
Is just for tracking for the next release, so we don’t forget to update some module. I remember someone suggested this recently, but I can’t remember in which PR. It does not need to go into the release changelog (in my opinion), but this way we know what needs to be updated !
There was a problem hiding this comment.
I see. As long as we are consistent, I feel like it should be fine. So far it seems like we only update the changelog if there are changes in the actual package but your argument for it being a "release reminder" is valid :).
|
@songy23 Sure, we'll take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates requests contrib to raise original exceptions, and updated tests.
Thanks @isra17 for noticing!