-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add httplib integration #95
Add httplib integration #95
Conversation
@@ -17,7 +17,8 @@ | |||
|
|||
log = logging.getLogger(__name__) | |||
|
|||
SUPPORTED_INTEGRATIONS = ['mysql', 'postgresql', 'sqlalchemy', 'requests'] | |||
SUPPORTED_INTEGRATIONS = ['httplib', 'mysql', 'postgresql', 'pymysql', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sort these alphabetically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
||
# No corresponding request span is found, request not traced. | ||
if span.span_id != current_span_id: | ||
return response_func(*args, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is missing the self
argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!
Closes #96