Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

[README] docker run ... incorrect #452

Closed
DazWilkin opened this issue Mar 1, 2019 · 1 comment
Closed

[README] docker run ... incorrect #452

DazWilkin opened this issue Mar 1, 2019 · 1 comment
Assignees
Milestone

Comments

@DazWilkin
Copy link

Both docker run (agent|collector) appear incorrect:

docker run --rm -it -p 55678:55678 -p 55679:55679 \
    -v $(pwd)/ocagent-config.yaml:/conf/ocagent-config.yaml \
    --config=/conf/ocagent-config.yaml \
    ocagent

The --config flag applies to the ocagent and must follow the ocagent container reference:

docker run --rm -it -p 55678:55678 -p 55679:55679 \
    -v $(pwd)/ocagent-config.yaml:/conf/ocagent-config.yaml \
   ocagent --config=/conf/ocagent-config.yaml

Please also consider defaulting to long flag names where available to aid comprehension:

docker run \
--rm \
--interactive \
--tty \
--publish=55678:55678 --publish=55679:55679 \
--volume=$(pwd)/ocagent-config.yaml:/conf/ocagent-config.yaml \
ocagent --config=/conf/ocagent-config.yaml
@pjanotti pjanotti self-assigned this Mar 1, 2019
@flands flands added this to the 0.1.4 milestone Mar 2, 2019
flands added a commit that referenced this issue Mar 2, 2019
@flands flands modified the milestones: 0.1.4, 0.2.0 Mar 14, 2019
@flands flands assigned flands and unassigned pjanotti Mar 28, 2019
@flands
Copy link
Contributor

flands commented Mar 28, 2019

Fixed by #458

@flands flands closed this as completed Mar 28, 2019
fivesheep pushed a commit to fivesheep/opencensus-service that referenced this issue Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants