This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Tracing: Add specifications on default TraceParams. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
requested review from
rakyll,
semistrict,
rghetia,
sebright,
g-easy and
dinooliva
rakyll
approved these changes
Jul 13, 2018
g-easy
approved these changes
Jul 16, 2018
@bogdandrutu Could you answer this question? |
|
The size of links is small so no memory issue to support 128, but probably the number is too high for real world use-cases. @songy23 I would reduce that to 32 probably. The reason for this is that if you have some kind of batching you likely have >10 batched operations (not always but sometime). |
|
SG, updated the limit on |
This was referenced Jul 16, 2018
|
thx folks |
g-easy
added a commit
to g-easy/opencensus-cpp
that referenced
this pull request
Jul 17, 2018
g-easy
added a commit
to census-instrumentation/opencensus-cpp
that referenced
this pull request
Jul 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #138.
/cc @bogdandrutu