Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Add base package with lerna, update README #1

Merged
merged 4 commits into from
Jan 8, 2019

Conversation

draffensperger
Copy link
Contributor

This use of lerna parallels the OpenCensus node use of it.

Having the web specific packages in a separate repo I think makes sense as it allows cleaner separation of Node vs. web functionality, and we can run separate test suites for each one. The @opencensus/core interfaces at least will be used in both places though so if it would be better to combine we can.

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nits. Thanks @draffensperger

lerna.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@draffensperger
Copy link
Contributor Author

@mayurkale22 does this look good? If so, can you approve?

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@draffensperger draffensperger merged commit 0cedb2b into master Jan 8, 2019
@draffensperger draffensperger deleted the readme-and-setup branch January 17, 2019 02:21
RenaultAI pushed a commit to RenaultAI/opencensus-web that referenced this pull request Nov 20, 2019
…trumentation#1)

This commit contains an initial prototype for the exporter daemon
that can discovered via and endpoint file on the host.

The exporter looks for the endpoint file to see the availability
of the daemon and exports if it is running.

Exporter daemon will allow OpenCensus users to export
without having to link a vendor-specific exporter in their final
binaries. We are expecting the prototype exporter is going to
be implemented in every language and registered by default.

Updates census-instrumentation/opencensus-specs#72.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants