This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Upgrade @opencensus/core dependency #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
approved these changes
Feb 25, 2019
| @@ -46,7 +48,7 @@ export class RootSpan extends Span implements coreTypes.RootSpan { | |||
| } | |||
| } | |||
|
|
|||
| startChildSpan(name?: string, kind?: string): Span { | |||
| startChildSpan(name?: string, kind?: SpanKind): Span { | |||
There was a problem hiding this comment.
May be in another PR, we should change startChildSpan signature to accept object instead of two params (similar to startRootSpan).
There was a problem hiding this comment.
Sure, I can do that. Added it here in this PR.
| @@ -43,7 +42,7 @@ | |||
| "access": "public" | |||
| }, | |||
| "devDependencies": { | |||
| "@opencensus/core": "^0.0.8", | |||
| "@opencensus/core": "0.0.9", | |||
There was a problem hiding this comment.
Here we are using "pin" dependency, but using semver range in opencensus-web-core package. I think we should be consistent across. WDYT?
There was a problem hiding this comment.
Good point - this was just a mistake. Changed it to the ^0.0.9 semver range to match opencensus-web-core and the other dependencies.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
@opencensus/coreto version0.0.9. The new version has changes to the span model, which required and enabled some light refactorings.The enums can't be directly imported from
@opencensus/coreor else that will create a runtime dependency since TypeScript enums (unlike interfaces and union types) have a real runtime result object. A runtime dependency on@opencensus/corecauses problems with the webpack build since it tries to find Node-specific things like async hooks, etc. This resolves the issue by just duplicating the enums in@opencensus/web-core.