-
Notifications
You must be signed in to change notification settings - Fork 21
OpenCensus Web B3 Propagation #173
OpenCensus Web B3 Propagation #173
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
d40ca99
to
e36f8f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=========================================
- Coverage 95.79% 95.7% -0.09%
=========================================
Files 30 32 +2
Lines 857 909 +52
Branches 148 162 +14
=========================================
+ Hits 821 870 +49
- Misses 36 39 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!! I just have one small nit, but otherwise LGTM. I will approve once we fix that comment.
packages/opencensus-web-instrumentation-zone-peer-dep/src/interaction-tracker.ts
Outdated
Show resolved
Hide resolved
e36f8f9
to
37fd8ff
Compare
Creates a new web package called
opencensus-web-b3-propagation
.The way web b3 propagation works is identical to nodejs/b3-propagation. In this package, it includes
web-core
for internal references (for example for random trace id generation).startTracing
is changed to acceptoptions = { propagation: Propagation }
.By default
opencensus/web-propagation-tracecontext.TraceContextFormat
will be used but it can be replaced withopencensus/web-propagation-b3.B3Format
@draffensperger am I on the right path? :)