Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

OpenCensus Web B3 Propagation #173

Merged

Conversation

edvinasbartkus
Copy link
Contributor

Creates a new web package called opencensus-web-b3-propagation.
The way web b3 propagation works is identical to nodejs/b3-propagation. In this package, it includes web-core for internal references (for example for random trace id generation).

startTracing is changed to accept options = { propagation: Propagation }.

By default opencensus/web-propagation-tracecontext.TraceContextFormat will be used but it can be replaced with opencensus/web-propagation-b3.B3Format

@draffensperger am I on the right path? :)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@edvinasbartkus
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@edvinasbartkus edvinasbartkus force-pushed the b3-propagation branch 2 times, most recently from d40ca99 to e36f8f9 Compare August 29, 2019 12:13
@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #173 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #173      +/-   ##
=========================================
- Coverage   95.79%   95.7%   -0.09%     
=========================================
  Files          30      32       +2     
  Lines         857     909      +52     
  Branches      148     162      +14     
=========================================
+ Hits          821     870      +49     
- Misses         36      39       +3
Impacted Files Coverage Δ
src/xhr-interceptor.ts 100% <0%> (ø) ⬆️
src/b3-format.ts 90.9% <0%> (ø)
src/validators.ts 100% <0%> (ø)
src/interaction-tracker.ts 96.46% <0%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd6a22...e36f8f9. Read the comment docs.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!! I just have one small nit, but otherwise LGTM. I will approve once we fix that comment.

@draffensperger draffensperger merged commit 06a6034 into census-instrumentation:master Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants