This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add HTTP span attribute keys #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
approved these changes
Feb 8, 2019
RenaultAI
pushed a commit
to RenaultAI/opencensus-web
that referenced
this pull request
Nov 20, 2019
Example config.yaml: stackdriver: project: "projectid" enableTraces: true zipkin: endpoint: "http://localhost:9411/api/v2/spans" Exporter will export the traces both to Stackdriver and Zipkin. Updates census-instrumentation#8.
RenaultAI
pushed a commit
to RenaultAI/opencensus-web
that referenced
this pull request
Nov 20, 2019
…nsus-instrumentation#536) * Add span attribute key mapping support (census-instrumentation#9) Many libraries and services didn't implement consistent naming for their span attribute keys, this feature provides the capability of making the attribute keys consistent for different libraries and services without the need to change their code. * PR Feedback * PR feedback * type on test Fix nil return and avoid lookup if overwritting Better syntax to avoid lookup when overwritting Support same replacement for multiple keys * Simplify handling of attribute related config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds constants for HTTP span labels from the spec plus a few more unofficial ones to accommodate fields in the browser performance timing API.
The opencensus-instrumentation-http package has similar constants as static attributes of a class but my initial impulse is that these are pretty static since they're in the official specs so copying them is cleaner than adding an dependency on the whole package.