Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

quickstart/{node, python}/metrics: Add tags for "status" and "error" #485

Merged
merged 2 commits into from
Nov 28, 2018

Conversation

hvent90
Copy link
Contributor

@hvent90 hvent90 commented Nov 28, 2018

Addresses #470

Part 2 of 2 pull request to reduce cognitive load as reviewing quickstarts is no simple task.

This PR does the following for the Node Metrics quickstart:

  1. Removes the "error" measure
  2. Creates a tag for "status" and "Error"
  3. Sets "status" tag to "OK"
  4. Added exception handling
  5. If error, "status" tag is set to "ERROR" and "error" tag is set to the error string

This PR does the following for the Python Metrics quickstart:

  1. Removes the "error" measure
  2. Creates a tag for "status" and "Error"
  3. Sets "status" tag to "OK"

Copy link
Member

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @hvent90!

@odeke-em odeke-em merged commit de28a67 into census-instrumentation:master Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants