Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Consolidate Agent and Collector documentation #637

Merged
merged 4 commits into from Mar 8, 2019
Merged

Consolidate Agent and Collector documentation #637

merged 4 commits into from Mar 8, 2019

Conversation

flands
Copy link
Contributor

@flands flands commented Mar 7, 2019

No description provided.

@flands flands requested review from odeke-em, songy23 and a team as code owners March 7, 2019 00:31
songy23
songy23 reviewed Mar 7, 2019
View reviewed changes
content/service/exporters/aws_xray/_index.md Outdated Show resolved Hide resolved
content/service/exporters/jaeger/_index.md Outdated Show resolved Hide resolved
content/service/exporters/prometheus/_index.md Outdated Show resolved Hide resolved
content/service/exporters/stackdriver/metrics.md Outdated Show resolved Hide resolved
content/service/exporters/stackdriver/tracing.md Outdated Show resolved Hide resolved
content/service/exporters/zipkin/_index.md Outdated Show resolved Hide resolved
@flands
Copy link
Contributor Author

flands commented Mar 7, 2019

great catch @songy23 -- should all be fixed now

songy23
songy23 approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except minor nits.

content/service/exporters/stackdriver/metrics.md Outdated Show resolved Hide resolved
content/service/exporters/stackdriver/tracing.md Outdated Show resolved Hide resolved
content/service/exporters/zipkin/_index.md Outdated Show resolved Hide resolved
@flands
Copy link
Contributor Author

flands commented Mar 7, 2019

@songy23 thanks! fixed.

@odeke-em
Copy link
Member

odeke-em commented Mar 7, 2019

Hello @flands, thank you for working on this! Let's try to ensure that all the old links work since the agent has been documented and viewable for almost a month now and got quite a lot of reception. One can do this in Hugo in the new locations by using the aliases keyword in the header by aliases: [/old_location_1, /old_location_2] as per
screen shot 2019-03-06 at 8 54 13 pm

@flands
Copy link
Contributor Author

flands commented Mar 7, 2019

@odeke-em this is great to know -- thanks! I am very new to hugo. I assume you put together the demos -- great work, they are impressive!

@flands
Copy link
Contributor Author

flands commented Mar 7, 2019

@odeke-em added aliases as requested

@flands
Copy link
Contributor Author

flands commented Mar 8, 2019

@odeke-em @songy23 friendly ping

@songy23 songy23 merged commit c1bc188 into census-instrumentation:master Mar 8, 2019
@flands flands deleted the service branch March 8, 2019 17:40
@odeke-em
Copy link
Member

odeke-em commented Mar 8, 2019

Thank you for working on this @flands and @songy23 for the review!

My apologies for the late reply @flands, I was swamped yesterday and also thank you for the kind words, yes in deed I put together almost all the demos on the website.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@songy23 songy23 songy23 approved these changes

@odeke-em odeke-em Awaiting requested review from odeke-em odeke-em is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flands @odeke-em @songy23 @googlebot