compare DC to state of VA, not DC itself #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't do what I expect it to do. I'd think that it is replacing the "State" of DC with the "State" of VA, but that's not what I get:
TBH, I'm having some trouble tracing the flow and don't have a ton of time to spend on it, but I saw this dangling and thought it ought to get a look, and get caught up with other changes in the API so that this PR doesn't go stale. In short, still needs to be verified. |
|
Verified. I think we may still not see it unless we go around clearing caches, which is kind of tedious, but locally, I see it working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iandees @JoeGermuska this should get approval before merging, I think. It's intended to close censusreporter/censusreporter#108
I broke out a
special_case_parentsfunction in case we need to do other things like this, which I think is the lightest-touch way of getting at this. Hate the hard-coded solutions, but don't really see a better way around the problem.