fix: scan and documentation issues #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbutera
force-pushed
the
ericbutera/docs-docker
branch
2 times, most recently
from
7134eac
to
1a8cda2
Compare
andrewalexander
approved these changes
Oct 6, 2023
The exception was being caught, but the error was still shown. This causes confusion as it appears the run had a "hard error" which is not true.
This removes a reference to a custom configuration option that no longer exists. Our deployment now follows standard AWS configuration.
ericbutera
force-pushed
the
ericbutera/docs-docker
branch
from
70a973b
to
aa3cbe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws_profilein AWS ECS terraform deployment