Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI-Build Fix #135

Merged
merged 1 commit into from
Feb 7, 2022
Merged

CI-Build Fix #135

merged 1 commit into from
Feb 7, 2022

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Feb 7, 2022

The new major release of pytest causing problems, this PR restricts pytest version to use on the build.

@emmanvg
restrict pytest version to use on the build.
091f429 
the new major release is causing problems
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@emmanvg emmanvg requested a review from mehaase February 7, 2022 15:49
@emmanvg emmanvg added this to the v1.1.2 milestone Feb 7, 2022
@emmanvg
Copy link
Contributor Author

emmanvg commented Feb 7, 2022 •
edited

@mehaase the safety check is not passing, but that should be addressed in #133. I would:

  • Merge this first, restart the GitHub Actions on 133 to be certain CI passes.
  • Continue with the other dependabot PR for nltk. (restart the GitHub Actions too)

m3mike
m3mike approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@m3mike m3mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes CI issue

@emmanvg emmanvg merged commit ff2e51e into master Feb 7, 2022
@emmanvg emmanvg deleted the pytest-ci-fix branch February 7, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m3mike m3mike m3mike approved these changes

@mehaase mehaase Awaiting requested review from mehaase

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emmanvg @m3mike