Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTID-14] Fixed Sentence Display #143

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Feb 8, 2022

What Changed?

  • Attack technique was not changed to attack object, breaks that tab.

This commit was cherry-picked 4e15c10 from @bsnyder70 on PR #129 . It had to be merge-conflicted in order to push it in.

closes #126

Attack technique was not changed to attack object, breaks that tab
@emmanvg emmanvg added this to the v1.1.2 milestone Feb 8, 2022
@emmanvg emmanvg requested a review from m3mike February 8, 2022 15:24
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #143 (0793a6a) into master (3364047) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          20       20           
  Lines         832      832           
=======================================
  Hits          787      787           
  Misses         45       45           
Impacted Files Coverage Δ
src/tram/tram/views.py 94.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3364047...0793a6a. Read the comment docs.

@emmanvg emmanvg requested a review from mehaase February 8, 2022 15:41
@emmanvg emmanvg merged commit e4037d0 into master Feb 8, 2022
@emmanvg emmanvg deleted the bug/ctid-14/sentence-display-fix branch February 8, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentence Display Error
2 participants