Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTID-18] Provide user information for uploads #147

Merged
merged 14 commits into from
Feb 15, 2022

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Feb 10, 2022

What Changed?

  • This PR provides current user (from web request) to populate created_by field for a submission
  • For manual submissions using the pipeline command, it create/uses a generic user called pipeline (manual) to capture how the information was submitted.
  • Reverted some pytest settings, it was causing too many Warnings in the output.

image

closes #83

for manual submissions using the pipeline create a generic user
@emmanvg emmanvg added this to the v1.1.3 milestone Feb 10, 2022
@emmanvg emmanvg requested a review from mehaase February 10, 2022 12:35
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #147 (953419b) into master (748b518) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   94.31%   94.35%   +0.03%     
==========================================
  Files          20       20              
  Lines         845      850       +5     
==========================================
+ Hits          797      802       +5     
  Misses         48       48              
Impacted Files Coverage Δ
src/tram/tram/ml/base.py 92.03% <ø> (ø)
src/tram/tram/serializers.py 95.16% <ø> (ø)
src/tram/tram/management/commands/pipeline.py 100.00% <100.00%> (ø)
src/tram/tram/models.py 100.00% <100.00%> (ø)
src/tram/tram/views.py 94.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748b518...953419b. Read the comment docs.

@emmanvg emmanvg self-assigned this Feb 10, 2022
src/tram/tram/management/commands/pipeline.py Outdated Show resolved Hide resolved
src/tram/tram/models.py Show resolved Hide resolved
@emmanvg emmanvg requested a review from mehaase February 15, 2022 15:15
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@emmanvg
Copy link
Contributor Author

emmanvg commented Feb 15, 2022

There seems to be a problem retrieving the image for the linter checks 🤔

@emmanvg
Copy link
Contributor Author

emmanvg commented Feb 15, 2022

The release is very recent, I suppose the packages still need to get created/distributed. https://github.com/github/super-linter/releases/tag/v4.9.0

@emmanvg
Copy link
Contributor Author

emmanvg commented Feb 15, 2022

Perfect, the image is up now!

@emmanvg emmanvg merged commit b5bf8a8 into master Feb 15, 2022
@emmanvg emmanvg deleted the bug/ctid-18/username-not-present-in-reports branch February 15, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload username does not display
2 participants