Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Allow for txt reports to be uploaded #148

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Conversation

mehaase
Copy link
Contributor

@mehaase mehaase commented Feb 10, 2022

Cherry picked from @bsnyder70's PR #129 to merge with linted code.

closes #120

@mehaase mehaase requested a review from emmanvg February 10, 2022 14:55
@mehaase mehaase self-assigned this Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #148 (cff8412) into master (eb7b8ea) will decrease coverage by 0.32%.
The diff coverage is 40.00%.

❗ Current head cff8412 differs from pull request most recent head 61b95fd. Consider uploading reports for the commit 61b95fd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   94.61%   94.28%   -0.33%     
==========================================
  Files          20       20              
  Lines         835      840       +5     
==========================================
+ Hits          790      792       +2     
- Misses         45       48       +3     
Impacted Files Coverage Δ
src/tram/tram/views.py 94.84% <ø> (ø)
src/tram/tram/ml/base.py 92.03% <40.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7b8ea...61b95fd. Read the comment docs.

src/tram/tram/ml/base.py Outdated Show resolved Hide resolved
src/tram/tram/ml/base.py Outdated Show resolved Hide resolved
@emmanvg emmanvg added this to the v1.1.3 milestone Feb 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@emmanvg emmanvg merged commit 36ba0b0 into master Feb 10, 2022
@emmanvg emmanvg deleted the upload-txt-report branch February 10, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept plain text format reports
2 participants