feat(export): add number of mappings in analyze and redownload report button #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… button 1. In analyze mode, show the number of mappings to the left of each sentence. 2. Add a button to download the original report file, i.e. verbatim copy of what the user uploaded.
… button Fix bugs in previous commit.
… button * Change this feature to use doc_id instead of doc name. * Escape doc name in header value * Don't show download button for docs that can't be downloaded (e.g. the bootstrap training data) as this introduces brittle edge cases.
… button Fix flake8 errors.
… button Fix more flake8 errors.
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 95.81% 95.63% -0.18%
==========================================
Files 9 9
Lines 836 848 +12
==========================================
+ Hits 801 811 +10
- Misses 35 37 +2
Continue to review full report at Codecov.
|
mehaase
changed the title
… button Rename function and add test coverage. (The new test exposed another test having some brittle code that assumes only one doc upload, so I made that test less brittle.)
mehaase
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
emmanvg
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from @bsnyder70's PR #129 to merge with linted code.
closes #87
closes #43