Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(auth): Persist the SECRET_KEY #154

Merged
merged 3 commits into from
Feb 15, 2022
Merged

refactor(auth): Persist the SECRET_KEY #154

merged 3 commits into from
Feb 15, 2022

Conversation

mehaase
Copy link
Contributor

@mehaase mehaase commented Feb 11, 2022

During development, every time you save a source file it reloads the
Django server which generates a new SECRET_KEY which means you have to
log in again, which is extremely tedious. This commit saves the
generated key to the data directory so that it can be reused.

Also modified code coverage to exclude settings.py and migrations.

During development, every time you save a source file it reloads the
Django server which generates a new SECRET_KEY which means you have to
log in again, which is extremely tedious. This commit saves the
generated key to the data directory so that it can be reused.
@mehaase mehaase requested a review from emmanvg February 11, 2022 19:09
@mehaase mehaase self-assigned this Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #154 (3317fa9) into master (b5bf8a8) will increase coverage by 1.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   94.35%   95.58%   +1.23%     
==========================================
  Files          20        8      -12     
  Lines         850      748     -102     
==========================================
- Hits          802      715      -87     
+ Misses         48       33      -15     
Impacted Files Coverage Δ
src/tram/tram/settings.py
...rc/tram/tram/migrations/0006_auto_20210618_1426.py
...igrations/0003_documentprocessingjob_created_by.py
...rc/tram/tram/migrations/0004_auto_20210429_1053.py
src/tram/tram/migrations/0001_initial.py
src/tram/tram/migrations/0008_attackgroup.py
...rc/tram/tram/migrations/0009_auto_20211209_1703.py
...rc/tram/tram/migrations/0005_auto_20210429_1246.py
...rc/tram/tram/migrations/0010_auto_20211209_1708.py
src/tram/manage.py
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bf8a8...3317fa9. Read the comment docs.

mehaase and others added 2 commits February 11, 2022 15:15
* Add django.key to .gitignore so nobody accidentally checks theirs in.
* Reconfigure code coverage to exclude settings.py and migrations.
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@emmanvg emmanvg added this to the v1.1.3 milestone Feb 15, 2022
@mehaase mehaase merged commit 1c9ff5d into master Feb 15, 2022
@mehaase mehaase deleted the persist-secret-key branch February 15, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants