SonarCloud findings #156
Merged
SonarCloud findings #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 95.63% 95.63% -0.01%
==========================================
Files 9 9
Lines 848 847 -1
==========================================
- Hits 811 810 -1
Misses 37 37
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
mehaase
reviewed
Feb 22, 2022
| @@ -75,7 +75,7 @@ function loadSentences(active_sentence_id) { | |||
| function storeSentences(sentences) { | |||
| stored_sentences = {}; | |||
| for (var i = 0; i < sentences.length; i++) { | |||
| sentence = sentences[i]; | |||
| var sentence = sentences[i]; | |||
There was a problem hiding this comment.
Not that it matters here, but in general you almost always want let in JavaScript rather than var.
mehaase
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
General findings from SonarCloud
tram runserverwithout setting the DEBUG flag.