Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment variable not evaluated correctly in config #459

Closed
binoculars opened this issue Sep 29, 2017 · 1 comment
Closed

environment variable not evaluated correctly in config #459

binoculars opened this issue Sep 29, 2017 · 1 comment

Comments

@binoculars
Copy link
Member

@pattisdr

https://github.com/CenterForOpenScience/ember-preprints/blob/ddb252cd0cf72a5056737e58b8292b9f543dd485/config/environment.js#L61

[process.env.KEEN_ENVIRONMENT] || ['production']

should be:

[process.env.KEEN_ENVIRONMENT || 'production']

the first one always evaluates to an array, which is truthy (production never gets referenced). I don't think it affects anything, just for reference. Alternatively, we can use object destructuring with default values.

@alexschiller
Copy link
Contributor

@baylee-d is actually fixing this because it did cause some weirdness for a keen related PR. Closing this issue so I don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants