Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on windows #2961

Closed
spapas opened this issue Jun 22, 2023 · 6 comments · Fixed by #3107
Closed

Does not work on windows #2961

spapas opened this issue Jun 22, 2023 · 6 comments · Fixed by #3107
Assignees
Labels
type: bug Something isn't working user reported Reported by a Mathesar user work: backend Related to Python, Django, and simple SQL
Milestone

Comments

@spapas
Copy link
Contributor

spapas commented Jun 22, 2023

Description

This cannot work on Windows because of the pglast dependency. Unfortunately it seems that this is an issue of the libpg_query library and probably will never be fixed: pganalyze/libpg_query#44

Expected behavior

To be able to install the dependencies on windows

To Reproduce

Try to instal requirements on windows

Environment

Windows 10, python 3.9.

Additional context

If I remove the pglast dependency pip install -r requirements-dev.txt works fine. I believe that this can be resolved by removing pglast completely since it's used only once. I'd be happy to discuss this more.

@spapas spapas added status: triage type: bug Something isn't working labels Jun 22, 2023
@mathemancer
Copy link
Contributor

The good news is that we're currently moving the logic that necessitated pglast down into the database, and so this requirement will be obsolete in the near future.

@rajatvijay rajatvijay added status: draft and removed type: bug Something isn't working status: triage labels Jun 26, 2023
@rajatvijay rajatvijay added the type: bug Something isn't working label Jun 26, 2023
@kgodey kgodey added work: backend Related to Python, Django, and simple SQL work: database labels Jun 26, 2023
@kgodey kgodey added this to the Backlog milestone Jun 26, 2023
@kgodey kgodey added the user reported Reported by a Mathesar user label Jun 26, 2023
@spapas
Copy link
Contributor Author

spapas commented Jul 19, 2023

Hello friends, do we have any news for this issue? I think it would be very useful if we removed that pglast dependency so people could run this under windows (I know I want to because I prefer windows for developing, now I need to ssh to a unix machine to run mathesar).

Thank you

@mathemancer
Copy link
Contributor

Update for you @spapas : We're still working on moving logic down to the database. Unfortunately, the logic requiring the use of pglast isn't yet moved out of python. I'll look at what it would take to do that sooner rather than later, since we expect to do it at some point regardless.

A quick inspection of the relevant code makes it look like we'd just need one (admittedly technical) function in the database to make it happen.

@spapas
Copy link
Contributor Author

spapas commented Jul 19, 2023

Thank you for the update @mathemancer !

@spapas
Copy link
Contributor Author

spapas commented Jul 28, 2023

@mathemancer I'm happy to report that mathesar runs on my windows machine (without docker) !

@kgodey
Copy link
Contributor

kgodey commented Jul 28, 2023

Thanks for confirming, @spapas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working user reported Reported by a Mathesar user work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants