Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI to filter on a value being NULL #789

Closed
seancolsen opened this issue Nov 1, 2021 · 6 comments
Closed

Add UI to filter on a value being NULL #789

seancolsen opened this issue Nov 1, 2021 · 6 comments
Labels
ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@seancolsen
Copy link
Contributor

Problem

User has no way to add a filter condition specifying that a value should be NULL.

Proposed solution

In addition to "Equals" and "Not Equals", we should have an "Is NULL" option when setting a filter condition.

@seancolsen seancolsen added type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory ready Ready for implementation labels Nov 1, 2021
@pavish
Copy link
Member

pavish commented Nov 1, 2021

@seancolsen The filters are meant to be dynamic i.e anything related to column types is meant to be dynamic.

For eg., for the type Number, the server should provide what kind of filters are applicable for number, what input type should be shown within the table, the grouping options we should allow for it, the icons required for it etc., This way we can easily add and remove types without having to update any frontend code, making it possible to provide data types as plugins.

I'm not sure how well we'd be able to get it done for the alpha release. But it's part of the frontend stories you could see in https://github.com/centerofci/mathesar/milestone/11 and an additional issue that tracks some of it: #661

This is to say that the "Equals" and "Not Equals" are both temporary conditions that were hardcoded on the frontend, and they would be eventually provided by the server, which will include isNull.

@kgodey I assume this is our plan for the alpha. Please let us know if you think it would be better to hardcode type specific properties on the frontend instead.

@kgodey
Copy link
Contributor

kgodey commented Nov 1, 2021

@pavish I think you should hardcode them for now and we can remove the hardcoding once #661 is completed. That way, we have the freedom to put off #661 until after the alpha release if needed.

@pavish
Copy link
Member

pavish commented Nov 1, 2021

@kgodey Thanks. Sounds good to me.

@seancolsen seancolsen self-assigned this Nov 2, 2021
@seancolsen seancolsen added status: started and removed ready Ready for implementation labels Nov 2, 2021
@seancolsen seancolsen added this to the [07] Working with Tables milestone Nov 5, 2021
@pavish
Copy link
Member

pavish commented Dec 2, 2021

@seancolsen I think this can wait until type configuration is complete as part of #500.

@pavish pavish added needs: unblocking Blocked by other work and removed status: started labels Dec 2, 2021
@seancolsen seancolsen removed their assignment Jan 21, 2022
@pavish
Copy link
Member

pavish commented Jan 24, 2022

This issue also depends on the new filters structure.

Blocked by #1001 and #500

@kgodey kgodey added ready Ready for implementation and removed needs: unblocking Blocked by other work labels May 2, 2022
@pavish
Copy link
Member

pavish commented May 2, 2022

Closing this issue since it's no longer relevant. The filters are based on each column type and they contain the filter is empty which handles this usecase.

@pavish pavish closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

3 participants