Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the loading skeleton when deleting rows #1351

Merged

Conversation

Jinxiao0302
Copy link
Contributor

@Jinxiao0302 Jinxiao0302 commented May 5, 2022

Related to #1289

The loading skeleton is not showing in unrelated cells now when deleting rows.

Technical details
Added an extra parameter in fetch function of records.ts, which is set to be true in deleting is called:
fetch(
retainExistingRows = false,
isDeleteOperation = false
)

Screen shot

deleting.rows.mp4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Jinxiao0302 Jinxiao0302 requested review from a team and pavish and removed request for a team May 5, 2022 01:47
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #1351 (9151093) into master (ad0c9b0) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
+ Coverage   93.71%   93.78%   +0.06%     
==========================================
  Files         114      114              
  Lines        4439     4518      +79     
==========================================
+ Hits         4160     4237      +77     
- Misses        279      281       +2     
Flag Coverage Δ
pytest-backend 93.78% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
db/records/operations/group.py 98.11% <0.00%> (-0.39%) ⬇️
mathesar/api/pagination.py 78.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0c9b0...9151093. Read the comment docs.

@kgodey kgodey added the pr-status: review A PR awaiting review label May 5, 2022
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jinxiao0302 Nice work!

I made a small change to re-use the existing argument instead of the new argument which was introduced: dd3ab08

@pavish pavish enabled auto-merge May 12, 2022 13:16
@pavish pavish merged commit a7745f4 into mathesar-foundation:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants