New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the loading skeleton when deleting rows #1351
Removed the loading skeleton when deleting rows #1351
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
+ Coverage 93.71% 93.78% +0.06%
==========================================
Files 114 114
Lines 4439 4518 +79
==========================================
+ Hits 4160 4237 +77
- Misses 279 281 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fixed code formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jinxiao0302 Nice work!
I made a small change to re-use the existing argument instead of the new argument which was introduced: dd3ab08
Related to #1289
The loading skeleton is not showing in unrelated cells now when deleting rows.
Technical details
Added an extra parameter in fetch function of records.ts, which is set to be true in deleting is called:
fetch(
retainExistingRows = false,
isDeleteOperation = false
)
Screen shot
deleting.rows.mp4
Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin