Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move constraint creation to SQL #2952

Merged
merged 34 commits into from Jun 23, 2023
Merged

Move constraint creation to SQL #2952

merged 34 commits into from Jun 23, 2023

Conversation

mathemancer
Copy link
Contributor

@mathemancer mathemancer commented Jun 19, 2023

Related to #2690

This PR removes SQLAlchemy from constraint creation calls, and adds an add_constraints function on the database that can add constraints to a preexisting table.

Technical details

Removes SQLAlchemy from the files:

  • db/constraints/base.py
  • db/constraints/operations/create.py
  • db/constraints/utils.py
  • mathesar/api/serializers/constraints.py

This also adds a number of SQL layer tests to cover constraint adding and copying, and removes some python layer tests that were made redundant.

NOTE Not all python-layer functions have new docstrings, since we're going to rework the python layer when solving #2850 .

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

unique, foreign key, and primary key constraints are covered.
This functionality is now covered by SQL tests. Consider updating
API tests to more completely ensure proper wiring.
@mathemancer mathemancer marked this pull request as ready for review June 20, 2023 15:31
@mathemancer mathemancer added the pr-status: review A PR awaiting review label Jun 20, 2023
Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The test cases look comprehensive but I found the test case names hard to parse on the first look.

@silentninja silentninja added this pull request to the merge queue Jun 23, 2023
Merged via the queue into develop with commit 9ccbb35 Jun 23, 2023
13 checks passed
@silentninja silentninja deleted the constraint_create_sql branch June 23, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants