New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move constraint creation to SQL #2952
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unique, foreign key, and primary key constraints are covered.
This functionality is now covered by SQL tests. Consider updating API tests to more completely ensure proper wiring.
silentninja
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The test cases look comprehensive but I found the test case names hard to parse on the first look.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2690
This PR removes SQLAlchemy from constraint creation calls, and adds an
add_constraints
function on the database that can add constraints to a preexisting table.Technical details
Removes SQLAlchemy from the files:
db/constraints/base.py
db/constraints/operations/create.py
db/constraints/utils.py
mathesar/api/serializers/constraints.py
This also adds a number of SQL layer tests to cover constraint adding and copying, and removes some python layer tests that were made redundant.
NOTE Not all python-layer functions have new docstrings, since we're going to rework the python layer when solving #2850 .
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin