Removing SQLAlchemy 1 #2690

mathemancer · 2023-03-16T07:49:03Z

Related to #2737

This removes SQLAlchemy imports from:

db.tables.operations.alter and
db.tables.operations.drop.

Technical details

This also adds some scaffolding functions in db.connection that can be used to avoid wrangling around function signatures until later in the process. These help us run the new functions with old SQLAlchemy objects.

It also has a couple of prototype database functions for

Getting the joinable tables, and
Setting up the Mathesar Views we'll use for DQL operations in the future.

The SQL scripts setting these up need to be run manually if you want to use them, since they're not yet integrated into the overall project.

Checklist

My pull request has a descriptive title (not a vague title like Update index.md).
My pull request targets the develop branch of the repository
My commit messages follow best practices.
My code follows the established code style of the repository.
I added tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

dmos62

Interesting read. Didn't manage to get through everything tonight, will finish next week.

db/sql/prototype.sql

dmos62 · 2023-03-17T19:18:57Z

db/sql/prototype.sql

+-- Update table primary key sequence to latest -----------------------------------------------------
+
+CREATE OR REPLACE FUNCTION
+__msar.update_pk_sequence_to_latest(table_name text, column_ text) RETURNS text AS $$/*


Is this compatible with multi-column PKs?

No, this is a direct port of the current python function (which also doesn't handle multi-column primary keys).

My plan is to get the current logic ported over while making minimal changes. I'm hoping to use pretty much the same test suite.

However, reviewing all this is a great opportunity to write up bugs and issues about exactly this sort of thing.

I'm pretty sure (hoping) that this function is only called when we're already sure it's a single-column primary key, namely when we've set the default id column as SERIAL PRIMARY KEY after the splitting logic runs. If that's wrong, we definitely need a bug report issue for this.

dmos62 · 2023-03-17T19:37:10Z

db/sql/prototype.sql

+    viewname, viewcols, __msar.get_table_name(table_id)
+  );
+END;
+$$ LANGUAGE plpgsql RETURNS NULL ON NULL INPUT;


Do I understand this correctly? A Mathesar view is a reflection of a user table. A Mathesar view is algorithmically named according to the user table's oid. Its column values are the reflected user table's column values, and its columns' names are the corresponding reflected table columns' attnums. Would be great to put this in a docstring somewhere around here.

You understand correctly. I'll figure out some reasonable way to document the purpose of these views, and how they work.

… sql_prototyping

dmos62

Approving. Also asked for a non-critical improvement.

dmos62 · 2023-03-21T16:40:42Z

db/install.py

@@ -30,6 +35,8 @@ def install_mathesar(
        if database_created:
            print(f"Installing Mathesar on PostgreSQL database {database_name} at host {hostname}...")
            install.install_mathesar_on_database(user_db_engine)
+            with open(PROTOTYPE_FILE) as f, engine.begin() as conn:
+                conn.execute(text(f.read()))


Could you export executing the prototype SQL into a function and replace this block and the indentical blocks on line 23 and on conftest.py:79 with that? Will make it easier to maintain.

Naturally. This bit was a little too prototypey.

dmos62 · 2023-03-22T12:15:23Z

Looking good. Ping me if you think this needs a last review.

mathemancer · 2023-03-23T04:28:12Z

@dmos62 Code-wise, this is ready. I'm just setting up some of the surrounding (meta)issues and project stuff so that I can note them in the PR description here for the convenience of future code archaeologists.

mathemancer added 4 commits March 15, 2023 23:42

add prototype SQL functions for table alter functions

d0f7496

add view creator function, reorganize

da833f4

add view creation trigger, view dropping function

0f4cb95

reformat and document code for easier understanding

23c505b

mathemancer requested a review from dmos62 March 16, 2023 07:49

mathemancer added 4 commits March 16, 2023 15:51

fix forgotten name changes

f725bcd

extract table OID getting function

12e4cca

port over function to get joinable tables

136ce2c

Merge branch 'develop' into sql_prototyping

728b9ee

pavish added status: draft pr-status: review A PR awaiting review and removed status: draft labels Mar 16, 2023

pavish assigned dmos62 Mar 16, 2023

pavish added this to the Backlog milestone Mar 16, 2023

dmos62 reviewed Mar 17, 2023

View reviewed changes

mathemancer and others added 11 commits March 20, 2023 15:11

Merge branch 'develop' into sql_prototyping

bd797f4

add psycopg 3 for calling SQL from Python

571c349

add table dropping function, comment out view trigger

8af186b

add scaffolding function to make running commands easier

462fe43

add scaffolding to install new prototype SQL

cb048af

add python wrappers for alter and drop functions

4ad1711

fix dropping tests

4b62c4b

Merge branch 'develop' into sql_prototyping

a874a2a

Fix bugs to get tests passing

b7d42ee

Merge branch 'sql_prototyping' of github.com:centerofci/mathesar into…

458835f

… sql_prototyping

Merge branch 'develop' into sql_prototyping

018b2f3

dmos62 approved these changes Mar 21, 2023

View reviewed changes

mathemancer added 3 commits March 22, 2023 09:36

reorganize SQL, improve documentation and comments

d0b3859

tidy up linting issues

1afef6c

use extracted sql installer in tests

2bb1bf7

mathemancer added 2 commits March 22, 2023 10:54

reorganize and add documentation for joinable tables

1e9395b

fix path to SQL install script

f34e479

mathemancer marked this pull request as ready for review March 22, 2023 03:01

mathemancer changed the title ~~Sql prototyping~~ Removing SQLAlchemy 1 Mar 22, 2023

rajatvijay assigned mathemancer and unassigned dmos62 Mar 22, 2023

rajatvijay added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Mar 22, 2023

mathemancer added this pull request to the merge queue Mar 23, 2023

mathemancer merged commit f62dd21 into develop Mar 23, 2023

mathemancer deleted the sql_prototyping branch March 23, 2023 06:43

mathemancer mentioned this pull request Jun 19, 2023

Move constraint creation to SQL #2952

Merged

7 tasks

mathemancer mentioned this pull request Jun 27, 2023

Column creation and duplication DDL 2 #2978

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing SQLAlchemy 1 #2690

Removing SQLAlchemy 1 #2690

mathemancer commented Mar 16, 2023 •

edited

dmos62 left a comment

dmos62 Mar 17, 2023

mathemancer Mar 20, 2023

dmos62 Mar 17, 2023

mathemancer Mar 20, 2023

dmos62 left a comment

dmos62 Mar 21, 2023

mathemancer Mar 22, 2023

dmos62 commented Mar 22, 2023

mathemancer commented Mar 23, 2023

Removing SQLAlchemy 1 #2690

Removing SQLAlchemy 1 #2690

Conversation

mathemancer commented Mar 16, 2023 • edited

Checklist

Developer Certificate of Origin

dmos62 left a comment

Choose a reason for hiding this comment

dmos62 Mar 17, 2023

Choose a reason for hiding this comment

mathemancer Mar 20, 2023

Choose a reason for hiding this comment

dmos62 Mar 17, 2023

Choose a reason for hiding this comment

mathemancer Mar 20, 2023

Choose a reason for hiding this comment

dmos62 left a comment

Choose a reason for hiding this comment

dmos62 Mar 21, 2023

Choose a reason for hiding this comment

mathemancer Mar 22, 2023

Choose a reason for hiding this comment

dmos62 commented Mar 22, 2023

mathemancer commented Mar 23, 2023

mathemancer commented Mar 16, 2023 •

edited