Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column creation and duplication DDL 2 #2978

Merged
merged 20 commits into from Jul 2, 2023
Merged

Column creation and duplication DDL 2 #2978

merged 20 commits into from Jul 2, 2023

Conversation

mathemancer
Copy link
Contributor

Related to #2690

This PR is another step in moving column creation/duplication DDL operations to the database.

Technical details

  • modifies the python layer to use the column creation functions created in Add SQL for column adding #2923
  • adds a column_copy function at the SQL layer, uses it in python
  • Removes a bunch of python layer tests that were made redundant by new SQL layer tests

TODO

There is still a 'bulk create' function for columns in the python layer:

db.columns.operations.create.bulk_create_mathesar_column

This function won't be replaced, but will be deleted entirely when moving the table splitting/merging/column moving logic to the DB. So, we've skipped it for now.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer
Copy link
Contributor Author

To the reviewer:

It's probable that we still need to remove more python layer tests, or rework some fixtures. I think we should leave the bulk of test refactoring till after the functionality is complete.

@mathemancer mathemancer requested a review from dmos62 June 27, 2023 03:42
@mathemancer mathemancer added the pr-status: review A PR awaiting review label Jun 27, 2023
db/columns/operations/create.py Show resolved Hide resolved
db/columns/operations/create.py Show resolved Hide resolved
db/columns/operations/create.py Outdated Show resolved Hide resolved
db/sql/0_msar.sql Show resolved Hide resolved
db/sql/0_msar.sql Show resolved Hide resolved
db/sql/0_msar.sql Outdated Show resolved Hide resolved
@mathemancer mathemancer requested a review from dmos62 June 30, 2023 07:53
END LOOP;
RETURN format('%s %s', original_col_name, idx);
END;
$$ LANGUAGE plpgsql RETURNS NULL ON NULL INPUT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have been happy with the SQL version, but I think it's smart to dumb-down non-critical code 👍.

db/sql/0_msar.sql Outdated Show resolved Hide resolved
format_type(atttypid, atttypmod),
-- set the duplicate column to be nullable, since it will initially be empty
false,
-- set set the default value for the duplicate column if specified
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are very useful.

FROM pg_attribute AS pg_columns
JOIN unnest(col_ids, new_names) AS columns_to_copy(col_id, new_name)
ON pg_columns.attnum=columns_to_copy.col_id
LEFT JOIN pg_attrdef AS pg_column_defaults
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finding these aliases useful.

END,
', '
) AS not_nulls
FROM unnest(not_null_defs) as col
FROM unnest(not_null_defs) as not_null_def
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Dominykas Mostauskis <2715476+dmos62@users.noreply.github.com>
@mathemancer mathemancer added this pull request to the merge queue Jul 2, 2023
Merged via the queue into develop with commit 0d99ee9 Jul 2, 2023
14 checks passed
@mathemancer mathemancer deleted the column_ddl_2 branch July 2, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants