Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build from source documentation #3029

Merged
merged 5 commits into from Jul 21, 2023

Conversation

deka014
Copy link
Contributor

@deka014 deka014 commented Jul 11, 2023

Fixes #3013

Technical details

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@rajatvijay rajatvijay added the pr-status: revision A PR awaiting follow-up work from its author after review label Jul 12, 2023
@rajatvijay rajatvijay added this to the Backlog milestone Jul 12, 2023
@rajatvijay rajatvijay added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Jul 17, 2023
@kgodey kgodey modified the milestones: Backlog, v0.1.3 Jul 17, 2023
@dmos62 dmos62 self-requested a review July 19, 2023 08:10
@dmos62 dmos62 assigned dmos62 and unassigned silentninja Jul 19, 2023
@dmos62
Copy link
Contributor

dmos62 commented Jul 19, 2023

I'll review it, since the relevant issue is part of my backend fixes project.

dmos62
dmos62 previously requested changes Jul 19, 2023
Copy link
Contributor

@dmos62 dmos62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'll merge in a moment after I commit a slight change to wording.

docs/docs/installation/build-from-source/index.md Outdated Show resolved Hide resolved
@dmos62
Copy link
Contributor

dmos62 commented Jul 19, 2023

On second thought, @silentninja would you mind giving this a second look?

Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @deka014! It looks good to me

@silentninja silentninja added this pull request to the merge queue Jul 21, 2023
Merged via the queue into mathesar-foundation:develop with commit 0fe767d Jul 21, 2023
4 checks passed
@deka014 deka014 deleted the build-docs branch July 21, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Make permissions requirements clear for gunicorn user
5 participants