Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create superuser page's stylings #3131

Merged
merged 2 commits into from Aug 17, 2023

Conversation

rajatvijay
Copy link
Contributor

@rajatvijay rajatvijay commented Aug 4, 2023

Fixes #3056

Technical details

  1. Created a new app_styled_base.html template that loads the component library stylings. It also has some common stylings used across templates.
  2. login_base.html & superuser_create.html extend app_styled_base.html

Screenshots
Screenshot 2023-08-04 at 8 23 32 AM
Screenshot 2023-08-04 at 8 24 58 AM
Screenshot 2023-08-04 at 8 25 11 AM
Screenshot 2023-08-04 at 8 25 51 AM
Screenshot 2023-08-04 at 8 33 17 AM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@rajatvijay rajatvijay added the pr-status: review A PR awaiting review label Aug 4, 2023
@rajatvijay rajatvijay added this to the v0.1.3 milestone Aug 4, 2023
@rajatvijay rajatvijay marked this pull request as ready for review August 4, 2023 03:11
@silentninja silentninja linked an issue Aug 7, 2023 that may be closed by this pull request
@kgodey kgodey self-assigned this Aug 7, 2023
@kgodey
Copy link
Contributor

kgodey commented Aug 7, 2023

Assigning myself to update the copy.

@kgodey kgodey removed their assignment Aug 7, 2023
@kgodey
Copy link
Contributor

kgodey commented Aug 7, 2023

Pushed a commit with updated copy, unassigned myself. My main objection was "Mathesar account", the concept of having full control over your Mathesar account doesn't make sense. Renamed "account" to "installation".

Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the django-related code and it looks good to me!

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajatvijay

Looks good!

I'd like the file app_styled_base.html to be renamed to something more clearer, something like server_rendered_base.html, as to not confuse with the existing base.html.

I'm approving the PR. Please feel free to rename the file in the same PR or a different one and merge this in.

@pavish pavish assigned rajatvijay and unassigned silentninja and pavish Aug 16, 2023
@silentninja silentninja merged commit c678309 into superuser-create Aug 17, 2023
16 checks passed
@silentninja silentninja deleted the superuser-create-page-stylings-fe branch August 17, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update the Mathesar superuser creation screen Django templates
4 participants