upgrade poi to 4.0.1 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This seems to work fine and finally allows to try upgrading to even newer versions of Apache POI as follow-up steps! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I tried to upgrade poi version to 4.0.1 and fix various crashes. The Java 8 related api used in poi 4.0.1 is resolved by coreLibraryDesugaring provided by Android. I also tested the generated poishadow_all.jar with Android 5 (API 21) using emulator. Hope this pull request can resolve issue #44.
BTW, POI 4.0.0 have weird bugs that will crash sample code such as XSSFColor constructor missing. So I bump the version to 4.0.1 directly.