Skip to content

Commit

Permalink
Revert "Update iconv commit to latest to support go1.6 cgo strict rule"
Browse files Browse the repository at this point in the history
This reverts commit e4d361c.
The above commit is not working properly as it will convert wrongly
characters. Seem to be caused by improper use pointer because iconv
expecting pointer to pointer which it seem to allocate the memory
internally. This allocated memory is not being passed out to
golang side as the converted characters is not visible to golang side.
This is a quick fix before proper inspection should be done on iconv
pkg. However, without that commit mean that this pkg can not support
go1.6 and above as document here:
golang/go#12416
  • Loading branch information
cention-sany committed Sep 22, 2016
1 parent e4d361c commit a68942c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/github.com/qiniu/iconv

0 comments on commit a68942c

Please sign in to comment.