Change css to fix problems with speakers and talks cards overflowing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colophonemes
approved these changes
Apr 20, 2018
src/templates/event.pug
Outdated
| @@ -37,7 +37,7 @@ block content | |||
| != contents | |||
| if moment(endDate).add(14,'days').isAfter(moment(),'day') && contactEmail | |||
| .event-basic-info-contact | |||
| | For more information email | |||
| | For more information email  | |||
There was a problem hiding this comment.
This is fine, also you can use a string:
.thing
| test text here#{' '}Not necessarily nicer-looking, but makes it clearer what the intent is
tasks/metalsmith.js
Outdated
| @@ -142,6 +142,7 @@ function build(buildCount){ | |||
|
|
|||
|
|
|||
| // START THE BUILD! | |||
| // TODO: what's this variable name doing? | |||
There was a problem hiding this comment.
Ah, colophonemes... A hangover from a veeery long time ago and lots of copypasta 🍝
More specifically, this should be called metalsmith. It's possible to run a single chain of calls without the assignment by using the constructor:
Metalsmith(__dirname)
.use(plugin1())
.build()However, we add some steps conditionally in production, so we have to assign to handle the breaks
const metalsmith = Metalsmith(__dirname)
.use(plugin1())
if (NODE_ENV === 'production') {
// do something expensive, like minifying HTML
metalsmith
.use(plugin2())
}
metalsmith.build()
src/templates/speaker.pug
Outdated
| @@ -42,13 +42,14 @@ block content | |||
| h2.speaker-talks-title Talks | |||
| .row | |||
| - var talkWidthClasses = ['col-sm-6','col-sm-offset-3','col-md-4', 'col-md-offset-4']; | |||
| //- TODO this is necessary for maximum height reasons, but throws of centering | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.