Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix wrong reload acl button position #12013

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix wrong reload acl button position #12013

wants to merge 1 commit into from

Conversation

tanguyvda
Copy link
Contributor

Description

jira: MON-15591

Fixes #11625 (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

without this PR:

  • connect a non admin user to your centreon
  • use private mode or another web brower to log in with an admin user
  • with your admin user, go to the administration -> acl -> reload acl menu
  • you'll notice that the reload acl icon is displayed at the top of the page instead of being in the right column of the table

with this patch, the icon is now displayed where it should be

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@tanguyvda tanguyvda requested review from a team, dmyios and wtermellil October 18, 2022 21:23
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kduret kduret mentioned this pull request Nov 8, 2022
Closed
11 tasks
@kduret
Copy link
Contributor

kduret commented Nov 8, 2022

migrated to centreon/centreon#144

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@callapa callapa callapa approved these changes

@kduret kduret kduret approved these changes

@TamazC TamazC TamazC approved these changes

@dmyios dmyios dmyios approved these changes

@wtermellil wtermellil wtermellil approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tanguyvda @kduret @callapa @TamazC @dmyios @wtermellil @jeremyjaouen