This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(secu): only return resources that you are allowed to see #9363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is no longer used for versions that uses gorgone instead of centcore
|
Kindly rename this PR ;) |
adr-mo
changed the title
sc979
suggested changes
Jan 5, 2021
adr-mo
changed the title
sc979
approved these changes
Jan 5, 2021
jeremyjaouen
approved these changes
Jan 6, 2021
loiclau
approved these changes
Jan 6, 2021
callapa
reviewed
Jan 6, 2021
| /** | ||
| * If ACLs on, then only return metrics linked to services that the user can see. | ||
| */ | ||
| if (!$centreon->user->admin) { |
There was a problem hiding this comment.
I think it would have been better to do a private method that you would have called
adr-mo
added a commit
that referenced
this pull request
Jan 6, 2021
* secu(poller): return only allowed poller resources types * codingstyle: pollers * secu(metrics): return only allowed metrics linked to service resources types * secu(metrics): list only allowed metrics * codingstyle: metrics * style: fix errors returned by phpcs * secu(externalcmd): remove dead code This code is no longer used for versions that uses gorgone instead of centcore * code-review: take feedbacks into account #1
adr-mo
added a commit
that referenced
this pull request
Jan 6, 2021
* secu(poller): return only allowed poller resources types * codingstyle: pollers * secu(metrics): return only allowed metrics linked to service resources types * secu(metrics): list only allowed metrics * codingstyle: metrics * style: fix errors returned by phpcs * secu(externalcmd): remove dead code This code is no longer used for versions that uses gorgone instead of centcore * code-review: take feedbacks into account #1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to:
For the security issue related to externalcmd an other PR will be made for the 19.10.x and 2.8.x will be made as in previous versions centcore was still used.
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist