-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use plugin location to find gstcefsubprocess bin #31
use plugin location to find gstcefsubprocess bin #31
Conversation
Thanks, I trust you tested the uninstalled case? |
also please fix up your commits :) |
19b384d
to
f6a203c
Compare
@MathieuDuponchelle never trust strangers online XD. I did test both installed and uninstalled, but I might have tested something wrong, so I would be more at ease if you give it a spin before merge, just in case. |
@ghostnumber7 OK, let me test then |
Works just fine, just a couple comments ( |
f6a203c
to
16e74cb
Compare
tried, failed, forced again xD |
yes, you need to force push after you've modified the history of a branch, not familiar with git? :) |
Use it daily but don't care much for all the "test" and "fix" commits on the log xD |
I see, for personal projects I don't care either, but it's always nicer to read a history that doesn't exclusively consist of variations on "WIP" :) |
For sure. I'll always comply with owner preferences, no worries :P |
Thanks again |
Nice :) So now when copying stuff around we wont get GPU error? |
presumably, I've only ever used the plugin from its build directory tbh :) |
Yes, it should allow for you to move it anywhere as long as the lib is in the same folder as the bin |
Related to talks on #28 and #30
Removes
target_compile_definitions
forgstcefsubprocess
andlocales
paths in favor of inferring path based on plugin location.