Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use plugin location to find gstcefsubprocess bin #31

Merged

Conversation

ghostnumber7
Copy link
Contributor

Related to talks on #28 and #30
Removes target_compile_definitions for gstcefsubprocess and locales paths in favor of inferring path based on plugin location.

@MathieuDuponchelle
Copy link
Collaborator

Thanks, I trust you tested the uninstalled case?

@MathieuDuponchelle
Copy link
Collaborator

MathieuDuponchelle commented Aug 13, 2021

also please fix up your commits :)

@ghostnumber7
Copy link
Contributor Author

@MathieuDuponchelle never trust strangers online XD. I did test both installed and uninstalled, but I might have tested something wrong, so I would be more at ease if you give it a spin before merge, just in case.
I tried to clean the commit log with force push, have no idea how to fixup xD

@MathieuDuponchelle
Copy link
Collaborator

@ghostnumber7 OK, let me test then

gstcefsrc.cc Outdated Show resolved Hide resolved
gstcefsrc.cc Outdated Show resolved Hide resolved
@MathieuDuponchelle
Copy link
Collaborator

Works just fine, just a couple comments (git commit -a --amend once you've fixed them), good work :)

@ghostnumber7
Copy link
Contributor Author

Works just fine, just a couple comments (git commit -a --amend once you've fixed them), good work :)

tried, failed, forced again xD

@MathieuDuponchelle MathieuDuponchelle merged commit 7ca0d69 into centricular:master Aug 13, 2021
@MathieuDuponchelle
Copy link
Collaborator

tried, failed, forced again xD

yes, you need to force push after you've modified the history of a branch, not familiar with git? :)

@ghostnumber7
Copy link
Contributor Author

tried, failed, forced again xD

yes, you need to force push after you've modified the history of a branch, not familiar with git? :)

Use it daily but don't care much for all the "test" and "fix" commits on the log xD

@ghostnumber7 ghostnumber7 deleted the feature/relocate branch August 13, 2021 22:11
@MathieuDuponchelle
Copy link
Collaborator

I see, for personal projects I don't care either, but it's always nicer to read a history that doesn't exclusively consist of variations on "WIP" :)

@ghostnumber7
Copy link
Contributor Author

I see, for personal projects I don't care either, but it's always nicer to read a history that doesn't exclusively consist of variations on "WIP" :)

For sure. I'll always comply with owner preferences, no worries :P

@MathieuDuponchelle
Copy link
Collaborator

Thanks again

@reinismu
Copy link
Contributor

Nice :) So now when copying stuff around we wont get GPU error?

@MathieuDuponchelle
Copy link
Collaborator

presumably, I've only ever used the plugin from its build directory tbh :)

@ghostnumber7
Copy link
Contributor Author

Nice :) So now when copying stuff around we wont get GPU error?

Yes, it should allow for you to move it anywhere as long as the lib is in the same folder as the bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants