fix builds on macos arm64 and pay attention to USE_SANDBOX flag #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyldin601
changed the title
|
And it actually works? From what I recall it couldn't launch cef properly. Started to look into it a while ago master...reinismu:gstcefsrc:macos-support Tho didn't get far |
|
@reinismu At least, it started compiling, but |
|
Hah, thanks for the patch I suppose, I will merge it because you say it makes things compile when they didn't before, but I don't really have a clue what we're doing here :) Good luck to you on making this actually work beyond compiling though, I hope you figure it out :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66