Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect improvements, avoid ClientDisconnectedError in _onPing #79

Merged
merged 5 commits into from
May 21, 2023

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented May 15, 2023

This should generally improve reconnect process by only scheduling reconnect routine in onDone handler of the transport. Thus reducing a chance of leaking connections. Also addresses #76 – no exception should be raised when pong message can't be written to closed transport.

@FZambia FZambia mentioned this pull request May 15, 2023
@TomBeckett
Copy link

Hey @FZambia 👋

Do we know when this may be merged & released?

Thanks!

@FZambia FZambia temporarily deployed to test_ci May 21, 2023 06:32 — with GitHub Actions Inactive
@FZambia FZambia merged commit b127c0d into master May 21, 2023
2 checks passed
@FZambia
Copy link
Member Author

FZambia commented May 21, 2023

@TomBeckett just released v0.9.4 - I suggest spending a bit more time than usual testing centrifuge-dart behaviour before moving to prod, hopefully it will work fine and exceptions go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants