Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to update to Starscream 4? #48

Closed
danqing opened this issue Aug 15, 2021 · 10 comments
Closed

Any plan to update to Starscream 4? #48

danqing opened this issue Aug 15, 2021 · 10 comments

Comments

@danqing
Copy link
Contributor

danqing commented Aug 15, 2021

As the topic says. Thanks!

@FZambia
Copy link
Member

FZambia commented Aug 15, 2021

Hello, there was a pull request #19, at that point Starscream 4 had several known problems.

Starscream not maintained well these days so I am not sure migration to v4 can give any benefit. Did you experience any problems with Starscream 3 which you aim to solve?

@danqing
Copy link
Contributor Author

danqing commented Oct 14, 2021

Not really but I remember seeing some ss 3 issues back in the day (before v4 came out), and just curious about the plan here. While ss isn't being maintained super well, there have been a bunch of updates for v4 and it's been over a year since #19 was created.

@fedulvtubudul
Copy link
Contributor

There are integration issues if you try to add both Socket.IO and Centrifuge via CocoaPods into same project (we use both for different services). SocketIO depends on Starscream ~>4.0.

@FZambia
Copy link
Member

FZambia commented Oct 29, 2021

That's unfortunate, but I think it would be better to embed StarScream 3 to Centrifuge-swift than migrating to StarScream 4 at this point – looking at StarScream issue tracker I am not really confident that upgrade to v4 worth it.

@FZambia
Copy link
Member

FZambia commented Nov 10, 2021

@fedulvtubudul opened a pr #53 to embed Starscream 3 for now till we find and migrate to a better alternative (which can take much more time). What do you think – is this viable for you?

@fedulvtubudul
Copy link
Contributor

@FZambia yep, thanks! Recently we've done the same on our fork to integrate Centrifuge into a project that already uses SocketIO. So now we can return to upstream which is great.

@FZambia
Copy link
Member

FZambia commented Nov 11, 2021

So CentrifugeSwift 0.4.2 now embeds Starscream 3 and does not have an external dependency to Starscream. I hope this is a temporary thing – but hard to say when we do the next step, as I said above – I am a bit worried about Starscream 4 state these days.

@FZambia
Copy link
Member

FZambia commented Jan 20, 2023

I suppose next step here would be: use native URLSessionWebSocketTask if available and fallback to our embedded Starscream 3 fork for older devices. Appreciate help with this.

@FZambia
Copy link
Member

FZambia commented Aug 3, 2023

Thanks to #84 we now have an optional WS transport using URLSessionWebSocketTask. Will be part of next release.

@FZambia
Copy link
Member

FZambia commented Oct 7, 2023

available in 0.7.0

@FZambia FZambia closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants