Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to mark positioned clients with insufficient state if publication lag exceeds threshold #385

Merged
merged 6 commits into from
May 26, 2024

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented May 26, 2024

In this PR we do not mark positioned clients with insufficient state upon receiving publication with the correct epoch but smaller offset.

We also introduce ClientChannelPositionMaxTimeLag option to mark positioned clients with insufficient state if publication lag exceeds threshold.

Also a histogram to monitor the time lag - time since publish till processing in Node's hub.

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 63.38028% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 81.65%. Comparing base (48fe37f) to head (efa97d0).

Current head efa97d0 differs from pull request most recent head 01f809e

Please upload reports for the commit 01f809e to get more accurate results.

Files Patch % Lines
client.go 45.83% 10 Missing and 3 partials ⚠️
broker_redis.go 56.25% 6 Missing and 1 partial ⚠️
metrics.go 69.23% 2 Missing and 2 partials ⚠️
hub.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   81.79%   81.65%   -0.14%     
==========================================
  Files          40       40              
  Lines        7046     7087      +41     
==========================================
+ Hits         5763     5787      +24     
- Misses        919      931      +12     
- Partials      364      369       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FZambia FZambia merged commit 5ad3b3d into master May 26, 2024
9 checks passed
@FZambia FZambia deleted the monitor_pub_sub_lag branch May 27, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant