Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip useless delta updates – send full payload instead #388

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Jun 9, 2024

If the size of delta patch is greater than full publication payload – skip sending delta, just use the full payload.

@FZambia FZambia changed the title Skip useless delta updates Skip useless delta updates – send full payload instead Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.64%. Comparing base (c5fffda) to head (09caeab).

Files Patch % Lines
client.go 0.00% 12 Missing ⚠️
hub.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   81.66%   81.64%   -0.03%     
==========================================
  Files          40       40              
  Lines        7103     7100       -3     
==========================================
- Hits         5801     5797       -4     
  Misses        931      931              
- Partials      371      372       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FZambia FZambia merged commit f41c0bf into master Jun 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant