Apply review comments

libs/types/src/domain_address.rs

@@ -27,8 +27,10 @@ use crate::EVMChainId;
 #[cfg_attr(feature = "std", derive(Debug))]
 pub enum Domain {
 	/// Referring to the Centrifuge Parachain. Will be used for handling
-	/// incoming messages. NOTE: messages CAN NOT be sent directly
-	/// from the Centrifuge chain to the Centrifuge chain itself.
+	/// incoming messages.
+	///
+	/// NOTE: messages CAN NOT be sent directly from the Centrifuge chain to the
+	/// Centrifuge chain itself.
 	Centrifuge,
 	/// An EVM domain, identified by its EVM Chain Id
 	EVM(EVMChainId),

pallets/liquidity-pools/src/contract.rs

@@ -13,7 +13,7 @@
 use ethabi::{Bytes, Contract};
 use sp_std::{vec, vec::Vec};
 
-/// The solidity LiquidityPool's XCMRouter handle function name.
+/// The solidity LiquidityPools' XCMRouter handle function name.
 static HANDLE_FUNCTION: &str = "handle";
 
 /// Return the encoded contract call, i.e,

runtime/common/Cargo.toml

@@ -74,12 +74,12 @@ std = [
   "frame-system/std",
   "pallet-authorship/std",
   "pallet-balances/std",
-  "pallet-liquidity-pools/std",
   "pallet-base-fee/std",
   "pallet-ethereum/std",
   "pallet-evm/std",
   "pallet-evm-chain-id/std",
   "pallet-evm-precompile-dispatch/std",
+  "pallet-liquidity-pools/std",
   "pallet-treasury/std",
   "sp-core/std",
   "sp-api/std",

runtime/development/Cargo.toml

@@ -160,7 +160,6 @@ std = [
   "chainbridge/std",
   "chainbridge/std",
   "codec/std",
-  "liquidity-pools-gateway-routers/std",
   "cumulus-pallet-aura-ext/std",
   "cumulus-pallet-parachain-system/std",
   "cumulus-pallet-xcm/std",
@@ -176,6 +175,7 @@ std = [
   "frame-system-benchmarking?/std",
   "frame-try-runtime/std",
   "hex/std",
+  "liquidity-pools-gateway-routers/std",
   "moonbeam-relay-encoder/std",
   "orml-asset-registry/std",
   "orml-tokens/std",
@@ -276,13 +276,13 @@ std = [
 runtime-benchmarks = [
   "cfg-types/runtime-benchmarks",
   "chainbridge/runtime-benchmarks",
-  "liquidity-pools-gateway-routers/runtime-benchmarks",
   "cumulus-pallet-session-benchmarking/runtime-benchmarks",
   "frame-benchmarking/runtime-benchmarks",
   "frame-support/runtime-benchmarks",
   "frame-system-benchmarking/runtime-benchmarks",
   "frame-system/runtime-benchmarks",
   "hex-literal",
+  "liquidity-pools-gateway-routers/runtime-benchmarks",
   "pallet-anchors/runtime-benchmarks",
   "pallet-balances/runtime-benchmarks",
   "pallet-block-rewards/runtime-benchmarks",
@@ -321,11 +321,11 @@ runtime-benchmarks = [
   "orml-tokens/runtime-benchmarks",
   "orml-xtokens/runtime-benchmarks",
   "pallet-bridge/runtime-benchmarks",
-  "pallet-liquidity-pools/runtime-benchmarks",
-  "pallet-liquidity-pools-gateway/runtime-benchmarks",
   "pallet-democracy/runtime-benchmarks",
   "pallet-elections-phragmen/runtime-benchmarks",
   "pallet-identity/runtime-benchmarks",
+  "pallet-liquidity-pools/runtime-benchmarks",
+  "pallet-liquidity-pools-gateway/runtime-benchmarks",
   "pallet-multisig/runtime-benchmarks",
   "pallet-membership/runtime-benchmarks",
   "pallet-preimage/runtime-benchmarks",
@@ -344,17 +344,17 @@ runtime-benchmarks = [
 ]
 
 try-runtime = [
-  "liquidity-pools-gateway-routers/try-runtime",
-  "pallet-liquidity-pools/try-runtime",
-  "pallet-liquidity-pools-gateway/try-runtime",
   "cfg-primitives/try-runtime",
   "cfg-traits/try-runtime",
   "cfg-primitives/try-runtime",
   "cfg-traits/try-runtime",
   "cfg-types/try-runtime",
+  "liquidity-pools-gateway-routers/try-runtime",
   "pallet-interest-accrual/try-runtime",
   "pallet-investments/try-runtime",
   "pallet-keystore/try-runtime",
+  "pallet-liquidity-pools/try-runtime",
+  "pallet-liquidity-pools-gateway/try-runtime",
   "pallet-liquidity-rewards/try-runtime",
   "pallet-loans/try-runtime",
   "pallet-nft-sales/try-runtime",

runtime/integration-tests/src/liquidity_pools/pallet/development/tests/liquidity_pools.rs

@@ -1802,7 +1802,7 @@ mod utils {
 					seniority: None,
 					metadata: TrancheMetadata {
 						// NOTE: For now, we have to set these metadata fields of the first tranche
-						// to be convertible to the 32-byte size expected by the liquidityPools
+						// to be convertible to the 32-byte size expected by the liquidity pools
 						// AddTranche message.
 						token_name: BoundedVec::<
 							u8,