Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectors: Restrict AddPool and AddTranche to PoolAdmin #1470

Closed
NunoAlexandre opened this issue Jul 28, 2023 · 1 comment · Fixed by #1472
Closed

connectors: Restrict AddPool and AddTranche to PoolAdmin #1470

NunoAlexandre opened this issue Jul 28, 2023 · 1 comment · Fixed by #1472
Assignees
@NunoAlexandre

Comments

@NunoAlexandre
Copy link
Contributor

two reasons:

  1. say coinbase wants to launch a pool on base just for their users, nothing stops a troll from deploying it elsewhere which they might not like
  2. if we use different bridges the security of a pool is worsened if you deploy it through a less secure bridge
@NunoAlexandre NunoAlexandre self-assigned this Jul 28, 2023
@mustermeiszer
Copy link
Collaborator

We should also restrict add_tranche then.

@NunoAlexandre NunoAlexandre mentioned this issue Jul 28, 2023
Merged
@NunoAlexandre NunoAlexandre changed the title connectors: Restrict AddPool to PoolAdmin connectors: Restrict AddPool and AddTranche to PoolAdmin Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NunoAlexandre NunoAlexandre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

connectors: Restrict AddPool and AddTranche to PoolAdmin centrifuge/centrifuge-chain
2 participants
@NunoAlexandre @mustermeiszer