Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectors: Restrict AddPool and AddTranche to PoolAdmin #1472

Merged
merged 2 commits into from Jul 28, 2023
Merged

connectors: Restrict AddPool and AddTranche to PoolAdmin #1472

merged 2 commits into from Jul 28, 2023

Conversation

NunoAlexandre
Copy link
Contributor

Closes #1470

Note: we also want to introduce a fee at least for AddPool, that's under discussion. We can choose to open a follow up PR for that other bit or wait on this one.

@NunoAlexandre NunoAlexandre self-assigned this Jul 28, 2023
wischli
wischli approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you update the spec as well after merging this?

@NunoAlexandre NunoAlexandre enabled auto-merge (squash) July 28, 2023 14:52
@NunoAlexandre NunoAlexandre merged commit 43bf08c into main Jul 28, 2023
11 checks passed
@NunoAlexandre NunoAlexandre deleted the connectors/restriction-n-fee branch July 29, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

@mustermeiszer mustermeiszer Awaiting requested review from mustermeiszer

Assignees

@NunoAlexandre NunoAlexandre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connectors: Restrict AddPool and AddTranche to PoolAdmin
2 participants
@NunoAlexandre @wischli