Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker workflow #1320

Merged
merged 14 commits into from
Apr 17, 2023
Merged

Update docker workflow #1320

merged 14 commits into from
Apr 17, 2023

Conversation

gpmayorga
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Changes and Descriptions

[List your changes here]

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

wischli
wischli previously approved these changes Apr 13, 2023
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpmayorga
Copy link
Contributor Author

I'd consider this ready to merge pending the decision if we want to go for the 4-core option (1h 15min build time) or the 8-core option (45 min build time)

@gpmayorga gpmayorga requested a review from wischli April 14, 2023 16:58
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the 4-core docker build (72 min = 1.152$) is a bit more cost-efficient than the 8-core (42 min = 1.344$), this seems to be the way.

Source: https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#per-minute-rates

@wischli wischli merged commit 8812cde into main Apr 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants