pallet-collection-data-feed implementation
#1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
D0-ready
4 tasks
libs/traits/src/data.rs
Outdated
| } | ||
|
|
||
| /// Abstration to represent a collection of datas in memory | ||
| pub trait DataCollection<DataId, Data, Moment> { |
There was a problem hiding this comment.
We have the same for interest rate right?
Would it make sense to merge them into a common collection trait?
There was a problem hiding this comment.
That would be great, but the parameters differ a little bit, the RateCollection uses two: interest_rate and normalized_debt, and in this case we only need a data_id. Maybe in a future refactor once #1310 is used instead.
There was a problem hiding this comment.
I've simplified the trait to allow in the future mixing DataCollection for this and interest accrual.
BTW, I'm thinking in removing |
hieronx
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new pallet to organize Oracle inputs into collections in order to read them better from consumers as
pallet-loans.Epic #1279
Changes and Descriptions
pallet-collection-data-feed