Fix default timestamp for portfolio valuation #1359
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
last_updated
field of portfolio valuation is only updating when the valuations are computed. This is ok, nevertheless, if a loan is added to a pool, and modified, it will affect the portfolio valuation without updating thelast_updated
, which by default will be created with0
instead ofnow()
This means that if some entity call
nav()
, before computing once the portfolio valuation, it will obtain an incorrect time (?). Not sure if this is a possible case or if we always call theupdate_portfolio_valuation()
at least once.Until I see it, the
pool-system
is protected when closing the epoch giving anNAVTooOld
error, but that means the epoch can not be closed (unlessupdate_porfolio_valuation()
is called).If it is a security issue, I understand we need to deliver a fix soon. In case not, and we can live with it, this will be fixed properly in the Oracle Valuation PR