Loans: LoanId out from ActiveLoan #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q1-easy
lemunozm
force-pushed
the
loans/loan-id-refactor
branch
from
7947886
to
b017a5e
Compare
hieronx
approved these changes
May 26, 2023
wischli
approved these changes
May 26, 2023
wischli
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a nitpicky change. But ideally, a
LoanIdshould not belong to theActiveLoanitself. ALoanIdis an id used to identify such a loan, and should be handled at the pallet level, not at the loan level.To rationale this, if instead of storing the
ActiveLoansin aVec, we would store it in aStorageMap, we should not place theLoanIdin theActiveLoanat the very beginning, as happen currently withCreatedLoansandClosedLoans, so how we store the loans should not affect the data they hold.