Loans: Add unchecked amount support #1368
Conversation
lemunozm
added
Q1-easy
| ) -> DispatchResult { | ||
| let who = ensure_signed(origin)?; | ||
|
|
||
| let (amount, _count) = Self::update_active_loan(pool_id, loan_id, |loan| { | ||
| Self::ensure_loan_borrower(&who, loan.borrower())?; | ||
| loan.repay(amount) | ||
| loan.repay(amount, unchecked_amount) | ||
| })?; |
There was a problem hiding this comment.
We should add unchecked_amount: T::Balance as the last parameter to the Repaid event.
There was a problem hiding this comment.
Actually, I see what's happening now, the amount logged in the event will include the unchecked amount. I fear an indexing layer needs to be able to know what the checked vs unchecked amount was.
There was a problem hiding this comment.
Maybe Loan::repay can return separate amount and unchecked amounts, rather than adding them together?
There was a problem hiding this comment.
Yes, In fact, I think Loan::repay shouldn't do anything with unchecked except stores it.
lemunozm
force-pushed
the
loans/unchecked-amount
branch
from
a8cc59a
to
838813a
Compare
| COLLATERAL_VALUE, | ||
| ),); | ||
|
|
||
| // Nothing repaid with unchecked amount, |
There was a problem hiding this comment.
Good straightforward test to check this behaviour 👍
There was a problem hiding this comment.
I think it would be good to update the comment above the repay extrinsic. Something like from
/// The origin must be the borrower of the loan.
/// If the repaying amount is more than current debt, only current debt
/// is transferred. The borrow action should fulfill the borrow
/// restrictions configured at [`types::LoanRestrictions`]. The `amount`
/// will be transferred from borrower to pool reserve. The portfolio
/// valuation of the pool is updated to reflect the new present value of
/// the loan.to
/// The origin must be the borrower of the loan.
/// The repay action should fulfill the repay restrictions
/// configured at [`types::RepayRestrictions`].
/// If the repaying `amount` is more than current debt, only current debt
/// is transferred. This does not apply to `unchecked_amount`, which
/// can be used to repay more than the outstanding debt.
/// The portfolio valuation of the pool is updated to reflect the new
/// present value of the loan.
Description
unchecked_amountinrepay()extrinsictotal_repaid_uncheckedtoActiveLoanstruct.Fixes #1352